Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async components ppx support #157

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Async components ppx support #157

merged 7 commits into from
Aug 13, 2024

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Aug 8, 2024 •
edited
Loading

This PR introduces a few changes:

  • Add a mechanism for wrapping the value_binding. Apply some constructor (Upper_case_component and Async_component) into the let make function.
  • Move React.Upper_case_component from the expression to the value_binding
  • Make [@react.async.component] wrap the value binding with Async_component

@davesnx
Wrap uppercase components and async components
5862a19
@davesnx
Re-use hasReactComponentAttr
fe9a3fa
@davesnx
Transform interfaces as well
6a53de9
@davesnx
Merge branch 'main' of github.com:ml-in-barcelona/server-reason-react…
a509f21 
… into async-components-ppx-support

* 'main' of github.com:ml-in-barcelona/server-reason-react:
  Name ignored variables
  Fix demo building with lwt on Dream
@davesnx
Wrap value bindings with (fun () -> expr)
4304556
@davesnx
Merge branch 'main' of github.com:ml-in-barcelona/server-reason-react…
f75edb3 
… into async-components-ppx-support

* 'main' of github.com:ml-in-barcelona/server-reason-react:
  Micro benchmark for rendering a string (#158)
  Add traverse to handle nested module with platform anotation (#161)
  Delete .envrc since isn't used
@davesnx
Remove Lwt.return from ppx
5a40715
@davesnx davesnx merged commit 26affb8 into main Aug 13, 2024
2 checks passed
@davesnx davesnx deleted the async-components-ppx-support branch August 13, 2024 17:04
davesnx added a commit that referenced this pull request Aug 28, 2024
@davesnx
Merge branch 'main' of github.com:ml-in-barcelona/server-reason-react…
334e4eb 
… into render-rsc-payload

* 'main' of github.com:ml-in-barcelona/server-reason-react:
  [`React.cloneElement`] Raise in any other case than lowercase element (#164)
  Make Js.Math.min/max
  Add native code to Js.String.split (#168)
  Async components ppx support (#157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davesnx