Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insufficient test #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix insufficient test #34

wants to merge 1 commit into from

Conversation

DrMurx
Copy link
Contributor

@DrMurx DrMurx commented Sep 27, 2024

The test didn't properly reference the finished variable, and tap.same(undefined, null) would be true, so we need tap.strictSame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant