Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert request.t and request_cgi.t to subtests #1584

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

kiwiroy
Copy link
Contributor

@kiwiroy kiwiroy commented Oct 26, 2020

Summary

Tests for Mojo::Message::Request in t/mojo/request.t and t/mojo/request_cgi.t converted to use subtests.

Motivation

Continuing ongoing effort

References

#1520

@kraih kraih requested a review from a team October 26, 2020 12:21
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

is $req->body, '', 'no content';
};

subtest 'Parse HTTP 1.1 message with huge "Cookie" header exceeding line limit (alternative)' => sub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get this on one line with -l=120 👍

@mergify mergify bot merged commit 50b1ea4 into mojolicious:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants