Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix error when scanning GitHub user repo #247

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Aug 4, 2023

Before, scanning a user repo with this policy resulted in two errors:

! resolver.db> failed to store data, types don't match asset=//policy.api.mondoo.com/assets/*** checksum=*** data={"type":"\u001bgithub.organization"} expected=block received=github.organization
x failed to send datapoints error="1 error occurred:\n\t* failed to store data for \"***\", types don't match: expected block, got github.organization\n\n"

and

cannot convert primitive with NO type information

related to mondoohq/cnquery#957

@czunker
Copy link
Contributor Author

czunker commented Aug 4, 2023

This is, how it looked like in the UI before this PR:
Screenshot from 2023-08-04 13-48-00

And after:
Screenshot from 2023-08-04 13-54-18

Copy link
Member

@atomic111 atomic111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czunker thank you!!!

Before, scanning a user repo with this policy resulted in two errors:

```
! resolver.db> failed to store data, types don't match asset=//policy.api.mondoo.com/assets/2TWAyduY7PG2mz6cThAiw6izaBH checksum=ykt2Zc3Oo80XLuytqsUSE6fkGlJZvq7kE0pZrR8YX027tEtyd8TYI7RxI8EWAuL8wTzhWljY4P3OYN3mdmohOA== data={"type":"\u001bgithub.organization"} expected=block received=github.organization
x failed to send datapoints error="1 error occurred:\n\t* failed to store data for \"ykt2Zc3Oo80XLuytqsUSE6fkGlJZvq7kE0pZrR8YX027tEtyd8TYI7RxI8EWAuL8wTzhWljY4P3OYN3mdmohOA==\", types don't match: expected block, got github.organization\n\n"
```

and

```
cannot convert primitive with NO type information
```

related to mondoohq/cnquery#957

Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
@czunker czunker force-pushed the christian/github_repo_no_type branch from d7d2abc to 54f8d5b Compare August 14, 2023 09:58
@czunker czunker merged commit 50d199e into main Aug 14, 2023
6 checks passed
@czunker czunker deleted the christian/github_repo_no_type branch August 14, 2023 11:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants