Add a filter to fix application of Azure check to just subscriptions #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think of adding it under the groups like the following for all of them? : and is there any specific reason asset.platform is needed as we have already asset.runtime? |
chris-rock
reviewed
May 14, 2024
| @@ -1387,44 +1385,47 @@ queries: | |||
| - uid: mondoo-azure-security-ensure-activity-log-alert-exists-for-create-update-delete-network-security-group | |||
| title: Ensure that activity log alerts exist for the commands Create, Update, and Delete Network Security Group | |||
| impact: 80 | |||
| filters: | | |||
| asset.platform == "azure" | |||
There was a problem hiding this comment.
Shouldn't this just run on a azure subscription?
There was a problem hiding this comment.
Yes sure, all of them run on Azure subscription
There was a problem hiding this comment.
platform of azure is the platform for the subscriptions
This should not run everywhere Signed-off-by: Tim Smith <[email protected]>
tas50
force-pushed
the
tas50/fix_azure_fine_grained
branch
from
82aaf1a
to
4eb8063
Compare
|
@HRouhani any chance you can take this one on when you get back and update the filters on the groups if that is what you'd like to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not run everywhere