Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⭐️ Adding Dockerfile best Security practices #426

Merged
merged 39 commits into from
Aug 8, 2024
Merged

⭐️ Adding Dockerfile best Security practices #426

merged 39 commits into from
Aug 8, 2024

Conversation

HRouhani
Copy link
Contributor

@HRouhani HRouhani commented Aug 7, 2024

No description provided.

@HRouhani
Adding Best security practices for Dockerfile
dc7ff36 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
root user test
537bb81 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
new tests
d1a8ae1 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
better mql
03b2d1a 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
certificate validation
998f84e 
Signed-off-by: Hossein Rouhani <[email protected]>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@HRouhani
certificate validation
6aa7579 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
adding apt check and tags
488c75a 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
format
10eaf4f 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
spell check
826e636 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
format issue
2a1ac34 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
format issue
13aaf3b 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
format issue
8133177 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani HRouhani marked this pull request as ready for review August 8, 2024 14:55
@HRouhani
filter issue
e182a83 
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani
improvements
69e94ec 
Signed-off-by: Hossein Rouhani <[email protected]>
HRouhani and others added 2 commits August 8, 2024 18:20
@HRouhani @tas50
Update core/mondoo-dockerfile-security.mql.yaml
f3b5584 
Co-authored-by: Tim Smith <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
@HRouhani @tas50
Update core/mondoo-dockerfile-security.mql.yaml
9d6e106 
Co-authored-by: Tim Smith <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
misterpantz
misterpantz reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation in this policy is excellent! I just made some minor suggestions for consistency and readability.

core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
core/mondoo-dockerfile-security.mql.yaml Outdated Show resolved Hide resolved
@tas50 tas50 merged commit 26c773a into main Aug 8, 2024
4 checks passed
@tas50 tas50 deleted the hossein/Dockerfile branch August 8, 2024 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@misterpantz misterpantz misterpantz left review comments

@tas50 tas50 tas50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HRouhani @tas50 @misterpantz