Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow anonymous function declarations #1418

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −5
Draft

Disallow anonymous function declarations #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/org/mozilla/javascript/Parser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,11 +888,13 @@ private FunctionNode function(int type, boolean isGenerator) throws IOException
syntheticType = FunctionNode.FUNCTION_EXPRESSION;
}

if (syntheticType != FunctionNode.FUNCTION_EXPRESSION
&& name != null
&& name.length() > 0) {
// Function statements define a symbol in the enclosing scope
defineSymbol(Token.FUNCTION, name.getIdentifier());
if (syntheticType != FunctionNode.FUNCTION_EXPRESSION) {
if (name != null && name.length() > 0) {
// Function statements define a symbol in the enclosing scope
defineSymbol(Token.FUNCTION, name.getIdentifier());
} else {
reportError("msg.fn.missing.name");
}
}

FunctionNode fnNode = new FunctionNode(functionSourceStart, name);
Expand Down
3 changes: 3 additions & 0 deletions src/org/mozilla/javascript/resources/Messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,9 @@ msg.let.decl.not.in.block =\
msg.bad.object.init =\
SyntaxError: invalid object initializer

msg.fn.missing.name =\
SyntaxError: function statements require a function name

# NodeTransformer
msg.dup.label =\
duplicated label
Expand Down