updating v8-symbols.js #1662
Merged
updating v8-symbols.js #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to the original test, weakmap does not support symbols as key (have tested that with real browsers). Therfore i had to comment some lines.
|
Looks good -- thanks! |
|
Thanks @gbrail - i guess you got the original file from the chrome folks - maybe we have to update that stuff to a recent version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As map/set/weakmap are supported by Rhino, we can enable one more test;
In contrast to the original test, weakmap does not support symbols as keys (have tested that with real browsers). Therfore I had to comment some lines.