Fix out of time use case virtual time tests #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pururun
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Rawa
force-pushed
the
fix-outoftimeusecasetest-virtual-time-assertions-droid-1372
branch
from
f54eadb
to
bd75b90
Compare
Rawa
force-pushed
the
fix-outoftimeusecasetest-virtual-time-assertions-droid-1372
branch
from
bd75b90
to
fa5e858
Compare
Rawa
deleted the
fix-outoftimeusecasetest-virtual-time-assertions-droid-1372
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The awaitItem() method from Turbine is used which causes delays to be skipped. This causes some tests to behave incorrectly where we want to assert that a given value is emitted after a specific delay. The solution is to instead use the expectMostRecentItem() method when we want to assert that an item has been emitted at a given point in time.
Further reading:
https://medium.com/@hi.enricog/explore-testing-coroutines-with-runtest-by-examples-4c4274a86a83
cashapp/turbine#265
This change is