Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate windows x86 installer to have one without architecture suffix #6885

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raksooo
Copy link
Member

@raksooo raksooo commented Sep 30, 2024

Until we have the universal Windows installer we want to upload the x64 installer but without the architecture suffix. This is to avoid making changes to other parts of the release process in the meanwhile.


This change is Reviewable

@raksooo raksooo requested a review from faern as a code owner September 30, 2024 08:29
@raksooo raksooo requested review from dlon and faern September 30, 2024 08:29
Copy link

linear bot commented Sep 30, 2024

Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @raksooo)


ci/buildserver-build.sh line 232 at r1 (raw file):

        pushd "$artifact_dir"
        for original_file in MullvadVPN-*-dev-*{.deb,.rpm,.exe,.pkg}; do
            new_file=$(echo "$original_file" | sed -nE "s/^(MullvadVPN-.*-dev-.*)(_amd64\.deb|_x86_64\.rpm|_arm64\.deb|_aarch64\.rpm|_x64\.exe|_arm64\.exe|\.pkg)$/\1$version_suffix\2/p")

Do we need to rename the .exe without a suffix here?

@raksooo raksooo force-pushed the make-buildserver-uplaod-exe-without-architechture-suffix-des-1274 branch from a300dff to 2ff7f11 Compare September 30, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants