Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pypluribus dependency, migrate to netmiko #42

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Remove pypluribus dependency, migrate to netmiko #42

wants to merge 3 commits into from

Conversation

mirceaulinic
Copy link
Member

@mirceaulinic mirceaulinic commented Mar 13, 2017 •
edited
Loading

After ktbyers/netmiko#408 is merged.

@mirceaulinic mirceaulinic added this to the 0.6.0 milestone Mar 13, 2017
@mirceaulinic mirceaulinic self-assigned this Mar 13, 2017
@dbarrosop
Copy link
Contributor

You can re-run tests on travis yourself, can't you?

@ktbyers
Copy link
Contributor

ktbyers commented Mar 15, 2017

I will release a new version of Netmiko shortly.

dbarrosop
dbarrosop approved these changes Mar 16, 2017
View reviewed changes
Copy link
Contributor

@dbarrosop dbarrosop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(deleted)

dbarrosop
dbarrosop reviewed Mar 16, 2017
View reviewed changes
Copy link
Contributor

@dbarrosop dbarrosop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realize this requires updating the mocked device. Could you fix it?

dbarrosop
dbarrosop requested changes Mar 16, 2017
View reviewed changes
Copy link
Contributor

@dbarrosop dbarrosop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realize this requires updating the mocked device. Could you fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarrosop dbarrosop dbarrosop requested changes

@ktbyers ktbyers Awaiting requested review from ktbyers

Assignees

@mirceaulinic mirceaulinic

Labels
enhancement transport_issue
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mirceaulinic @dbarrosop @ktbyers