Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isinstance(list) instead of types comparison in napalm/base/validate.py#L165 #1985

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Use isinstance(list) instead of types comparison in napalm/base/validate.py#L165 #1985

merged 1 commit into from
Aug 1, 2023

Conversation

jsenecal
Copy link
Contributor

@jsenecal jsenecal commented Aug 1, 2023

Fixes #1984

Use isinstance(list) instead of types comparison in napalm/base/validate.py#L165

bewing
bewing approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@bewing bewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bewing bewing merged commit b491dd2 into napalm-automation:develop Aug 1, 2023
6 checks passed
@jsenecal jsenecal deleted the use_isinstance branch August 1, 2023 15:16
@mirceaulinic mirceaulinic added this to the 5.0.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bewing bewing bewing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
3 participants
@jsenecal @bewing @mirceaulinic