[IOS][get_vlans()] Parse VLAN IDs when private VLANs are implemented

[vvas1lev]

=================
PRIMARY VLAN 2400
=================

XXX#sh vlan id 2400
VLAN Name                             Status    Ports
---- -------------------------------- --------- -------------------------------
2400 Vlan2400                         active    Po1
VLAN Type  SAID       MTU   Parent RingNo BridgeNo Stp  BrdgMode Trans1 Trans2
---- ----- ---------- ----- ------ ------ -------- ---- -------- ------ ------
2400 enet  102400     1500  -      -      -        -    -        0      0
Remote SPAN VLAN
----------------
Disabled
Primary Secondary Type              Ports
------- --------- ----------------- ------------------------------------------
2400    2432      community         Gi0/1, Gi0/2
2400    2433      community         Gi0/3, Gi0/4

===================
SECONDARY VLAN 2432
===================

XXX#sh vlan id 2432
VLAN Name                             Status    Ports
---- -------------------------------- --------- -------------------------------
2432 Vlan2432                         active    Po1
VLAN Type  SAID       MTU   Parent RingNo BridgeNo Stp  BrdgMode Trans1 Trans2
---- ----- ---------- ----- ------ ------ -------- ---- -------- ------ ------
2432 enet  102432     1500  -      -      -        -    -        0      0
Remote SPAN VLAN
----------------
Disabled
Primary Secondary Type              Ports
------- --------- ----------------- ------------------------------------------
2400    2432      community         Gi0/1, Gi0/2

Traceback (most recent call last):
  File "C:\Users\XXX\dev\python\net_tool\main.py", line 39, in <module>
    vlans = device.get_vlans()
            ^^^^^^^^^^^^^^^^^^
  File "C:\Users\XXX\dev\python\net_tool\venv\Lib\site-packages\napalm\ios\ios.py", line 3724, in get_vlans
    return self._get_vlan_from_id()
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\XXX\dev\python\net_tool\venv\Lib\site-packages\napalm\ios\ios.py", line 3795, in _get_vlan_from_id
    raise ValueError(
ValueError: Error parsing vlan_id 2432, found more values than can be present.

This change results in properly parsing the primary & secondary VLAN IDs.

[mirceaulinic]

@vvas1lev it seems like there's a conflict after merging #2010 (sorry!) - could you take took please?

[vvas1lev]

@mirceaulinic > @vvas1lev it seems like there's a conflict after merging #2010 (sorry!) - could you take took please?

Took a quick look but github actions (black) is failing despite it all being OK locally. I'll have another look some time next week.

(venv) X@X napalm % black --check .
All done! ✨ 🍰 ✨
110 files would be left unchanged.

[ktbyers]

@vvas1lev Which version of black do you have installed?

It needs to be black verson:

black-24.3.0

[vvas1lev]

@ktbyers that was it... thanks!

[mirceaulinic]

@vvas1lev - FYI the tests are still failing...

[bewing]

Probably need to add a strip call on this line somewhere given the failing test output

[mirceaulinic]

I gave this a try, and even with a strip() the tests would need the following in order to pass with this code:

diff --git a/test/ios/mocked_data/test_get_vlans/no_show_vlan_all_ports/expected_result.json b/test/ios/mocked_data/test_get_vlans/no_show_vlan_all_ports/expected_result.json
index da9cd8e0..ec258ac5 100644
--- a/test/ios/mocked_data/test_get_vlans/no_show_vlan_all_ports/expected_result.json
+++ b/test/ios/mocked_data/test_get_vlans/no_show_vlan_all_ports/expected_result.json
@@ -227,15 +227,13 @@
   "2432": {
     "name": "Vlan2432",
     "interfaces": [
-      "GigabitEthernet0/1",
-      "GigabitEthernet0/2"
+      "Port-channel1"
     ]
   },
   "2433": {
     "name": "Vlan2433",
     "interfaces": [
-      "GigabitEthernet0/3",
-      "GigabitEthernet0/4"
+      "Port-channel1"
     ]
   }
 }

So I believe there's more work required in this PR, re-scheduling for the next release.

[vvas1lev]

@mirceaulinic @bewing I figured it'd need more work, which is why I changed it back to draft. I'm just back from PTO, will take a look at this coming week.

[mirceaulinic]

Cool - thanks for the heads up @vvas1lev!