Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Registration Theme Configurable #12

Merged
merged 19 commits into from
May 16, 2024
Merged

Make Registration Theme Configurable #12

merged 19 commits into from
May 16, 2024

Conversation

jbouder
Copy link
Contributor

@jbouder jbouder commented May 13, 2024 •
edited
Loading

Description

  • Updated with default nebari theme
  • Updated to allow setting theme variables in the root from template
  • Misc refactoring

Related Issue

  • N/A

Motivation and Context

  • Provide base theme and allow for extension as needed

How Has This Been Tested?

  • Local Testing

Screenshots (if appropriate):

Base Theme

Screenshot 2024-05-14 at 8 20 47 AM

Custom Theme (provided through config)

Screenshot 2024-05-14 at 12 29 48 PM

jbouder added 16 commits May 13, 2024 12:08
@jbouder
Restructure app.
f51588a
@jbouder
Updates for local development.
3ccca0c
@jbouder
Add run script.
2faf7ab
@jbouder
Fix app path.
3048217
@jbouder
Add base nebari theme.
38dbab8
@jbouder
Add default theme config. Update to include theme in templates.
23c49c9
@jbouder
Update action for restructuring.
24fa22b
@jbouder
Fix docker build location.
abd81c5
@jbouder
Update readme.
dfaf083
@jbouder
Add sample config. Update readme.
c39c706
@jbouder
Add base template. Update index and success with template.
011071c
@jbouder
Update base with head block. Add head block to success page with copy…
5520912 
… functionality.
@jbouder
Misc refactoring.
6845079
@jbouder
Add dockerfile for local development. Update for new dockerfile.
532f61d
@jbouder
Update to check for config theme and default to default when not pres…
c381523 
…ent.
@jbouder
Update to better support theming with any or all values. Update to su…
f660ab6 
…pport full and relative logo urls.
@kenafoster kenafoster marked this pull request as ready for review May 16, 2024 13:25
@kenafoster kenafoster merged commit 4ee142d into main May 16, 2024
1 check passed
@marcelovilla marcelovilla mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc left review comments

@kenafoster kenafoster kenafoster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbouder @kenafoster @viniciusdc