Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Push for quay.io #22

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Update Docker Push for quay.io #22

merged 6 commits into from
Sep 26, 2024

Conversation

kenafoster
Copy link
Contributor

Changing the docker GH Action to push to Nebari's quay.io repository

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • [ X ] Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Changing the docker GH Action to push to Nebari's quay.io repository
@kenafoster kenafoster self-assigned this Sep 11, 2024
@kenafoster kenafoster changed the title WIP/DNM - Update Docker Push for quay.io Update Docker Push for quay.io Sep 26, 2024
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments:

  • The tagging is inconsistent with rest of the docker images.
  • You don't want to push the docker image on Pull requests.

But since the scope of this PR is to only change the docker registry where the images are pushed, we can tackle these in separate pull requests.

Looks good to me.

@aktech aktech merged commit 98be35a into main Sep 26, 2024
1 check passed
@aktech aktech deleted the gh-action_quay-update branch September 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants