-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compute): adds pg_session_jwt extension to compute image #8888
Conversation
5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
a257f8b at 2024-10-01T08:31:07.440Z :recycle: |
CC @devjv @conradludgate @stradig @vadim2404 Going to keep this as a Draft for now, but it works and you can all take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the compute node image can be built successfully I'm confident that this can be merged.
6ffb508
to
c0c2320
Compare
2951ea6
to
3a6576e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although maybe we shouldn't merge just yet. I don't think we have a way to feature gate extensions so it's best if we manually configure the compute images with this one built in CI for now
2b1fbca
to
1b3eddf
Compare
30855b5
to
00e0106
Compare
00e0106
to
0a45c08
Compare
0a45c08
to
57cceae
Compare
963c14f
to
9a3ebae
Compare
9a3ebae
to
6868028
Compare
6868028
to
a257f8b
Compare
Problem
We need the pg_session_jwt extension in the compute image. This PR adds it.
Summary of changes
I added the
pg_session_jwt
extension in a very similar way to how the pggraphql and pgtiktoken extensions were added (since they're all written with pgrx). Then I tested this.Checklist before requesting a review
Checklist before merging