Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] add filter iterator to disk btree. #9181

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yliang412
Copy link
Contributor

Problem

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Yuchen Liang <[email protected]>
Copy link

5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)


Flaky tests (6)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 32.0% (7512 of 23445 functions)
  • lines: 50.0% (60625 of 121150 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
5a87afd at 2024-09-27T14:57:50.365Z :recycle:

{
FilterDiskBtreeIter::new(self, predicate)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to me like this could be a futures::future::Stream, it would give you the (async) map and sync filter(?) right away without writing these up.

Comment on lines 550 to 552
stream: std::pin::Pin<
Box<dyn Stream<Item = std::result::Result<(Vec<u8>, u64), DiskBtreeError>> + 'a + Send>,
>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never understood why was this boxed, it does not need to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants