Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): only test num of L1 layers in compaction smoke test #9186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Sep 27, 2024

Problem

close #9160

For whatever reason, pg17's WAL pattern seems different from others, which triggers some flaky behavior within the compaction smoke test.

Summary of changes

  • Run L0 compaction before proceeding with the read benchmark.
  • So that we can ensure the num of L0 layers is 0 and test the compaction behavior only with L1 layers.

We have a threshold for triggering L0 compaction. In some cases, the test case did not produce enough L0 layers to do a L0 compaction, therefore leaving the layer map with 3+ L0 layers above the L1 layers. This increases the average read depth for the timeline.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh marked this pull request as ready for review September 27, 2024 18:28
@skyzh skyzh requested a review from a team as a code owner September 27, 2024 18:28
@skyzh skyzh changed the title fix(test): only test num of L1 layers in compaction smoke test fix(test): try to test num of L1 layers in compaction smoke test Sep 27, 2024
@skyzh skyzh changed the title fix(test): try to test num of L1 layers in compaction smoke test fix(test): only test num of L1 layers in compaction smoke test Sep 27, 2024
Copy link

5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.0% (7493 of 23433 functions)
  • lines: 50.0% (60520 of 121135 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
673b18f at 2024-09-27T19:23:07.252Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures in test_pageserver_compaction_smoke
1 participant