pageserver: add direct io config to virtual file #9214
Draft
+341
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need a way to incrementally switch to direct IO. During the rollout we might want to switch to O_DIRECT on image and delta layer read path first before others.
Summary of changes
VirtualFile
, current implementation becomeVirtualFileInner
open_v2
,create_v2
,open_with_options_v2
when we want to use the IO mode specified in PS config.As an example, we are using
open_v2
withvirtual_file::IoMode::Direct
in #9169Checklist before requesting a review
Checklist before merging