Ignore newaddr/deladdr notifications for unknown interfaces #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these would be labeled with the "__unknown" network interface name. This ended up causing more problems since code watching network interfaces would try to do things with the "__unknown" network. It also didn't help, the notifications were effectively ignored by stashing them there and it was impossible to use "__unknwon" since it could accumulate information from several network interfaces. The solution in this PR is to just drop the notifications. That doesn't change behavior for any code listening to real network interfaces. I do not know of any use of the "__unknown" interface. Messages are logged, but through my debug I couldn't find a reason to make more than debug level since I think they're artifacts of asynchronous cleanup of network interfaces.
|
Don't merge. This is more involved that I thought. It will need some additional thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these would be labeled with the "__unknown" network
interface name. This ended up causing more problems since code watching
network interfaces would try to do things with the "__unknown" network.
It also didn't help, the notifications were effectively ignored by
stashing them there and it was impossible to use "__unknwon" since it
could accumulate information from several network interfaces.
The solution in this PR is to just drop the notifications. That doesn't
change behavior for any code listening to real network interfaces. I do
not know of any use of the "__unknown" interface. Messages are logged,
but through my debug I couldn't find a reason to make more than debug
level since I think they're artifacts of asynchronous cleanup of network
interfaces.