Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update microcircuit docs regarding virtual process constraint and fix images #2823

Merged
merged 10 commits into from
Jul 4, 2023
Merged

Update microcircuit docs regarding virtual process constraint and fix images #2823

merged 10 commits into from
Jul 4, 2023

Conversation

jessica-mitchell
Copy link
Contributor

This PR adds a note to clarify that a single virtual process cannot be used to run the microcircuit model.
At the same time the images used in the microcircuit's README are fixed so they work now.

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 6, 2023
JanVogelsang
JanVogelsang suggested changes Jun 6, 2023
View reviewed changes
pynest/examples/Potjans_2014/sim_params.py Outdated Show resolved Hide resolved
pynest/examples/Potjans_2014/README.rst Outdated Show resolved Hide resolved
@terhorstd
Copy link
Contributor

terhorstd commented Jun 27, 2023 •
edited
Loading

@ackurth, could you briefly take a look? – Resulting build is here, explicitly the changed page here.

@jessica-mitchell jessica-mitchell mentioned this pull request Jun 27, 2023
Merged
@jessica-mitchell jessica-mitchell merged commit 1e6c911 into nest:master Jul 4, 2023
20 checks passed
@jessica-mitchell jessica-mitchell deleted the update-microcircuit-docs branch September 13, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackurth ackurth ackurth approved these changes

@JanVogelsang JanVogelsang JanVogelsang approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessica-mitchell @terhorstd @ackurth @JanVogelsang