Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice to iaf_cond_alpha_mc model documentation #3240

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Jun 27, 2024

Fixes #2461

Adding deprecation notice to the 'mc' models since the cm_default model is an improved implementation of compartmental neurons, as discussed in issue.

Models should be removed in an upcoming release.
Info about NEAT, once that has progressed could also be added.

See Read the Docs output here: https://nest-simulator--3240.org.readthedocs.build/en/3240/models/iaf_cond_alpha_mc.html

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 27, 2024
@ddahmen
Copy link
Contributor

ddahmen commented Jul 25, 2024

Please do not remove "pp_cond_exp_mc_urbanczik" because this model has a specific function to archive information that is needed for Urbanczik-Senn plasticity. To my knowledge, this feature is so far not included in the new cm_default model. Also the "pp_cond_exp_mc_urbanczik" implements exactly the model used in the original publication by Urbanczik and Senn and should therefore remain in NEST.

@jessica-mitchell jessica-mitchell changed the title Add deprecation notice to mc model documentation Add deprecation notice to iaf_cond_alpha_mc model documentation Jul 31, 2024
@terhorstd
Copy link
Contributor

LGTM, tiny change, I'll merge.

@terhorstd terhorstd merged commit d6bce1c into nest:master Aug 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Clarify difference between compartmental models and multi-compartment model
3 participants