Run context condition checks only once, after model parsing #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clinssen
force-pushed
the
symboltable_checks
branch
2 times, most recently
from
eec6c89
to
45f2a47
Compare
clinssen
force-pushed
the
symboltable_checks
branch
4 times, most recently
from
3f1e731
to
0ff3456
Compare
|
Bencher Report| Branch | 1105/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| bencher::mock_0 | 📈 view plot | 1.66 |
| bencher::mock_1 | 📈 view plot | 18.37 |
| bencher::mock_2 | 📈 view plot | 25.10 |
| bencher::mock_3 | 📈 view plot | 34.59 |
| bencher::mock_4 | 📈 view plot | 45.70 |
clinssen
force-pushed
the
symboltable_checks
branch
from
0ff3456
to
ceb4f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a spin-off from #1050.
Refactor cocos such that they run only once, after model parsing.
Fixes some other bugs that emerged as part of this refactor. For instance, two cocos turned out to actually make needed changes to the model; the modification part has now been spun off to the new AssignImplicitConversionFactorsTransformer. (I can also make the transformer into a pure visitor; please let me know if you prefer this approach.)