Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inprove channel join request processing #3261

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Inprove channel join request processing #3261

wants to merge 3 commits into from
+78 −188

Commits on Sep 29, 2024

  1. Combine code paths for handling channel joins 

    The existing code contains separate TLS and non-TLS code paths for
hadling channel join PDUs. This was introduced in
8fdc1ba and was based on a
misunderstanding of where in the connection sequence the TLS client hello
is processed (if a TLS connection is negotiated). The assumption was
the TLS client hello is received after the channel join PDUs. However,
it is actually received immediately after the X.224 Connection Confirm
PDU some time before channel join requests are processed.

Consequently, there is no reason not to adopt a single code path for
handling channel joins.
    @matt335672
    matt335672 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    7eb586d View commit details
    Browse the repository at this point in the history

  2. Announce server RNS_UD_SC_SKIP_CHANNELJOIN_SUPPORTED

    @matt335672
    matt335672 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    fcc82c3 View commit details
    Browse the repository at this point in the history

  3. Use client earlyCapabilities to determine channel join count 

    We always now indicate we support skipping channel joins. If the client
indicates this too, expect no channel join requests from the client.

If we do get some, process them anyway.
    @matt335672
    matt335672 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f4d7305 View commit details
    Browse the repository at this point in the history