Little framework for customizing the handling of low-level objects #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added dumps testing and debugging aid. Bail on OrderedDict. It's unclear what the correct JSON serialization is.
jamadden
approved these changes
Mar 2, 2017
| module, if so, you may just be able to use them. If not and | ||
| they're instances of ``GET`` or ``PUT`` objects, then they wrap | ||
| data which you can get via ``v`` attributes. If that doesn't | ||
| work, you may just need to give up. |
There was a problem hiding this comment.
I suppose these last few sentences are deliberately vague.
There was a problem hiding this comment.
Yes. Caveat emptor.
I tried to add reducers for the collections in the collections package and gave up (for now) because no collection had consistent arguments across versions in the travis tests. deque objects had args for Python 3.5 that were different than the args for Python 3.4, which were the same as the args for python 3.6. :/
|
OK, I'll go ahead and plumb this into Newt. |
|
I plumbed this into Newt and it's configs. This is ready for remaining review. :) |
|
Note that I'll fix tests and conflicts when a reviewer shows up. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very advanced feature and likely to be painful to use, but hopefully it will help when it's really needed.
Added a
dumpsfunction to help debug and understand JSON generation.Added logic to run the doctests in jsonpickle.