community-containers: add makemkv #4902
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/3889/add-makemkv
branch
from
ad30edf
to
16f3acd
Compare
20 tasks
szaimen
force-pushed
the
enh/3889/add-makemkv
branch
2 times, most recently
from
ffcfc06
to
deee36b
Compare
szaimen
commented
Jun 27, 2024
| ### Notes | ||
| - This container should only be run in home networks | ||
| - This container requires the [`NEXTCLOUD_MOUNT` variable in AIO to be set](https://github.com/nextcloud/all-in-one?tab=readme-ov-file#how-to-allow-the-nextcloud-container-to-access-directories-on-the-host). Otherwise the output will not be saved correctly. | ||
| - ⚠️ TODO: note down requirements regarding devices and also how to check if they are there... |
szaimen
force-pushed
the
enh/3889/add-makemkv
branch
from
deee36b
to
e2a3752
Compare
szaimen
commented
Jun 27, 2024
Comment on lines
+50
to
+52
| "/dev/sr0", -> check the devices for my drive, also add to readme that this device needs to be present | ||
| "/dev/sg2" -> check the devices for my drive, also add to readme that this device needs to be present |
There was a problem hiding this comment.
without a drive being connected:
root@cloud:~# ls /dev | grep ^sg
sg0
sg1
sg2
root@cloud:~# ls /dev | grep ^sr
root@cloud:~#
There was a problem hiding this comment.
so it looks like this cannot be automated as /dev/sg* is counted up for any device.... Need to think about a solution how to set them...
Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/3889/add-makemkv
branch
from
e2a3752
to
0ec3bee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of #3889