Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Configuration management #5328

Draft
wants to merge 7 commits into
base: enh/noid/optimize-psalm
Choose a base branch
from
Draft

Update Configuration management #5328

wants to merge 7 commits into from

Conversation

docjyJ
Copy link
Collaborator

@docjyJ docjyJ commented Sep 25, 2024

  • type checking when loading configuration.json
  • use an object representing the configuration
  • stop writing the file on each modification (single write)

It's in progress, what do you think?

@docjyJ
use space for indent
890bcc9 
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Typesafe ConfigurationController.php
d674ba4 
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Clean code and use const
56aa613 
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Clean ConfigurationController.php
c36ca0a 
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Refactor
5187ea6 
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Auth readonly class
1e4f32f 
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Wip
f7dfdf3 
Signed-off-by: Jean-Yves <[email protected]>
@szaimen szaimen changed the base branch from main to enh/noid/optimize-psalm September 27, 2024 08:54
@docjyJ
Copy link
Collaborator Author

docjyJ commented Sep 28, 2024

What do you think of this organization? It's not finished yet, but I would like to know if the management seems good or too complicated?

@docjyJ docjyJ self-assigned this Sep 28, 2024
@docjyJ docjyJ changed the title Refactor 2 Update Configuration managment Sep 28, 2024
@docjyJ docjyJ changed the title Update Configuration managment Update Configuration management Sep 28, 2024
@docjyJ docjyJ added 2. developing Work in progress enhancement New feature or request labels Sep 28, 2024
@docjyJ docjyJ mentioned this pull request Oct 2, 2024
Open
6 tasks
@szaimen
Copy link
Collaborator

szaimen commented Oct 2, 2024

What do you think of this organization? It's not finished yet, but I would like to know if the management seems good or too complicated?

I think it is a bit much currently... Lets first focus on #5308 and #5307 :)

@docjyJ
Copy link
Collaborator Author

docjyJ commented Oct 2, 2024

Yes, step by step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@docjyJ docjyJ

Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@docjyJ @szaimen