Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Silenced false warnings #131

Closed
wants to merge 3 commits into from
Closed

Conversation

mattheww95
Copy link

Parameters listed in nextflow_schema.json that are nested using the dot '.' operator no and are marked as ignored in the nextflow.config longer throw a warning. This fixes to bug mentioned here: #129

Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good temporary solution until we add support for the nested params, thank you! @mirpedrol can you have a look too? :)

Copy link
Collaborator

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too as a temporary solution!

I would suggest adding a TODO comment to change this once nested parameters are supported.
And maybe also a debug message saying that the parameter was ignored, but this is only a small suggestion, not a strong requirement :)

@nvnieuwk
Copy link
Collaborator

Hi @mattheww95 nf-validation will soon be deprecated. Can you please re-open your PR to nf-schema instead?

@nvnieuwk
Copy link
Collaborator

PR has been moved to nf-schema: nextflow-io#26

@nvnieuwk nvnieuwk closed this Apr 23, 2024
@mattheww95
Copy link
Author

Hi @mattheww95 nf-validation will soon be deprecated. Can you please re-open your PR to nf-schema instead?

Gladly! I see you already did the work for me however! Thank you so much

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants