Ensure etc directory is not changed while running unit tests

ngiger · Feb 26, 2024 · 611f238 · 611f238
1 parent dc640f0
commit 611f238
Show file tree

Hide file tree

Showing 23 changed files with 55 additions and 51 deletions.
diff --git a/src/plugin/csv_export.rb b/src/plugin/csv_export.rb
@@ -148,6 +148,7 @@ def export_fachinfo_chapter(term, chapters, lang, file)
     def export_ddd_csv
       @options = { }
       recipients.concat ['log']
+      FileUtils.makedirs(EXPORT_DIR)
       @file_path = File.join EXPORT_DIR, 'ddd.csv'
       CSV.open(@file_path, "w", col_sep: ';', encoding: 'UTF-8') do |csv|
         csv << [:iksnr,
@@ -191,6 +192,7 @@ def export_ddd_csv
       end
     end
     def export_index_therapeuticus
+      FileUtils.makedirs(EXPORT_DIR)
       @options = { }
       recipients.concat self.class::ODDB_RECIPIENTS
       ids = @app.indices_therapeutici.sort.collect { |code, idx| idx.odba_id }
@@ -236,6 +238,7 @@ def export_oddb_dat_with_migel(transfer)
       @file_path = output
       @options ||= {}
       @options[:compression] = 'zip'
+      FileUtils.makedirs(File.dirname(output))
       gem_app = Oddb2tdat.new(input1, output, input2, transfer) # see help of oddb2tdat gem
       gem_app.target.push(:migel)
       gem_app.run

diff --git a/src/view/drugs/csv_result.rb b/src/view/drugs/csv_result.rb
@@ -489,7 +489,8 @@ def to_csv(keys, symbol=:active_packages, target=:atc_class)
     res.join('')
   end
 	def to_csv_file(keys, path, symbol=:active_packages, target=:atc_class)
-		File.open(path, 'w') do |fh|
+      FileUtils.makedirs(File.dirname(path))
+      File.open(path, 'w') do |fh|
       fh.puts to_csv(keys, symbol, target)
     end
 	end

diff --git a/test/data/ddd.csv b/test/data/ddd.csv
@@ -0,0 +1,2 @@
+iksnr;package;pharmacode;description;atc_code;available_roas;ddd_roa;ddd_dose;package_roa;package_dose;galenic_forms;price_public;ddd_price;calculation;variant
+;002;123456;seqname;C01DA02;O;O;95 mg;125 mg;O;Tabletten;103.40;;no calculation done;-1
diff --git a/test/helpers.rb b/test/helpers.rb
@@ -28,7 +28,16 @@ def initialize(root_dir, tests_to_run_in_isolation = [])
       |file|
     @tests_to_run_in_isolation << File.expand_path(File.join(root_dir, file))  }
   end
-
+
+    def check_etc(path)
+      res =  `git status etc`
+      if /barcode_to_text_info/.match(res)
+        puts "#{path} changed etc"
+        exit 5
+      else
+        puts "#{path} left etc unchanged" if $VERBOSE
+      end
+    end
   @@directories =  Hash.new
 
   def run_isolated_tests
@@ -51,7 +60,7 @@ def run_isolated_tests
         result = system(cmd)
         puts "#{Time.now}: OddbTestRunner::Running #{path} failed  " unless result
       end
-
+      check_etc(path)
       @@directories[path] = result
     }
   end
@@ -70,6 +79,7 @@ def run_normal_tests(tests2Run = Dir.glob(File.join(@rootDir, '**', '*.rb')))
         else
           # puts "require #{File.expand_path(file)}"
           require File.expand_path(file)
+          check_etc(file)
         end
     end
   end
@@ -87,7 +97,11 @@ def show_results_and_exit
     }
     diffSeconds = (Time.now - StartTime).to_i
     puts "#{Time.now}: OddbTestRunner::Overall result for #{@rootDir} is #{okay}"
-    puts "#{Time.now}: OddbTestRunner::Overall failing test_suites were \n#{problems.join("\n")}" if problems.size > 0
+    if problems.size > 0
+      puts "#{Time.now}: OddbTestRunner::Overall failing test_suites were \n#{problems.join("\n")}"
+    else
+      puts "All tests passed"
+    end
     puts "   Took #{(diffSeconds/60).to_i} minutes and #{diffSeconds % 60} seconds to run"
     exit 2 unless okay
     okay

diff --git a/test/test_command/accept_orphan.rb b/test/test_command/accept_orphan.rb
@@ -5,11 +5,9 @@
 
 $: << File.expand_path("../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'command/accept_orphan'
 
 module ODDB 

diff --git a/test/test_command/replace_fachinfo.rb b/test/test_command/replace_fachinfo.rb
@@ -4,9 +4,6 @@
 
 $: << File.expand_path("../../src", File.dirname(__FILE__))
 
-#require 'state/global'
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
 require 'command/replace_fachinfo'

diff --git a/test/test_plugin/csv_export.rb b/test/test_plugin/csv_export.rb
@@ -22,6 +22,8 @@
 module ODDB
   class TestCsvExportPlugin <Minitest::Test
     def setup
+      FileUtils.rm_rf(ODDB::WORK_DIR)
+#      FileUtils.cp(File.join(ODDB::TEST_DATA_DIR, 'csv/*.csv'), File.mo)
       @app    = flexmock('app')
       @plugin = ODDB::CsvExportPlugin.new(@app)
     end
@@ -632,6 +634,12 @@ def test_export_oddb_dat
                :log_group => log_group
               )
       export_server = flexmock('export_server', :compress => 'compress')
+      src = File.join(ODDB::TEST_DATA_DIR, 'csv/oddb.csv')
+      assert(File.exist?(src), "#{src} must exist")
+      dest = File.join(ODDB::EXPORT_DIR, 'oddb.csv')
+      FileUtils.makedirs(ODDB::EXPORT_DIR)
+      res = FileUtils.copy_file(src, dest, preserve: true, verbose: true)
+      assert(File.exist?(dest), "#{dest} must exist")
       temporary_replace_constant(@plugin, 'ODDB::CsvExportPlugin::EXPORT_SERVER', export_server ) do
         @plugin.instance_eval('@options = {}')
         assert_equal('compress', @plugin.export_oddb_dat(nil))
@@ -648,7 +656,12 @@ def test_export_oddb_dat_with_migel
               )
       export_server = flexmock('export_server', :compress => 'compress')
       export_dir = File.join(ODDB::TEST_DATA_DIR, 'csv')
-      puts export_dir
+      src = File.join(ODDB::TEST_DATA_DIR, 'csv/oddb.csv')
+      assert(File.exist?(src), "#{src} must exist")
+      dest = File.join(ODDB::EXPORT_DIR, 'oddb.csv')
+      FileUtils.makedirs(ODDB::EXPORT_DIR)
+      res = FileUtils.copy_file(src, dest, preserve: true, verbose: true)
+      assert(File.exist?(dest), "#{dest} must exist")
       temporary_replace_constant(@plugin, 'ODDB::CsvExportPlugin::MIGEL_EXPORT_DIR', export_dir ) do
         temporary_replace_constant(@plugin, 'ODDB::CsvExportPlugin::EXPORT_SERVER', export_server ) do
           @plugin.instance_eval('@options = {}')

diff --git a/test/test_state/admin/activeagent.rb b/test/test_state/admin/activeagent.rb
@@ -6,10 +6,9 @@
 $: << File.expand_path('..', File.dirname(__FILE__))
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'htmlgrid/select'
 require 'define_empty_class'
 require 'state/admin/activeagent'

diff --git a/test/test_state/admin/assign_fachinfo.rb b/test/test_state/admin/assign_fachinfo.rb
@@ -4,10 +4,9 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'htmlgrid/labeltext'
 require 'state/admin/assign_fachinfo'
 

diff --git a/test/test_state/admin/entity.rb b/test/test_state/admin/entity.rb
@@ -4,10 +4,9 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'state/admin/entity'
 
 module ODDB

diff --git a/test/test_state/admin/orphaned_patinfo.rb b/test/test_state/admin/orphaned_patinfo.rb
@@ -4,10 +4,9 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'state/admin/orphaned_patinfo'
 require 'util/pointerarray'
 

diff --git a/test/test_state/admin/patinfo_deprived_sequences.rb b/test/test_state/admin/patinfo_deprived_sequences.rb
@@ -4,10 +4,9 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'state/admin/patinfo_deprived_sequences'
 
 module ODDB

diff --git a/test/test_state/admin/powerlinkuser.rb b/test/test_state/admin/powerlinkuser.rb
@@ -4,8 +4,10 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-
+require 'minitest/autorun'
+require 'flexmock/minitest'
 require 'state/global'
+
 module ODDB
   module State
     module Drugs
@@ -15,8 +17,6 @@ class RootFachinfo < Fachinfo; end
   end
 end
 
-require 'minitest/autorun'
-require 'flexmock/minitest'
 require 'state/admin/powerlinkuser'
 
 module ODDB

diff --git a/test/test_state/admin/poweruser.rb b/test/test_state/admin/poweruser.rb
@@ -4,8 +4,6 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
 require 'state/admin/poweruser'

diff --git a/test/test_state/admin/user.rb b/test/test_state/admin/user.rb
@@ -4,6 +4,8 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
+require 'minitest/autorun'
+require 'flexmock/minitest'
 require 'state/global'
 module ODDB
   module State
@@ -14,9 +16,6 @@ class RootFachinfo < Fachinfo; end
   end
 end
 
-
-require 'minitest/autorun'
-require 'flexmock/minitest'
 require 'state/admin/user'
 require 'state/admin/logout'
 require 'state/drugs/fachinfo'

diff --git a/test/test_state/drugs/package.rb b/test/test_state/drugs/package.rb
@@ -4,9 +4,6 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-#require 'state/global'
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
 require 'state/drugs/package'

diff --git a/test/test_state/drugs/sequences.rb b/test/test_state/drugs/sequences.rb
@@ -4,6 +4,8 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
+require 'minitest/autorun'
+require 'flexmock/minitest'
 require 'state/global'
 module ODDB
   module State
@@ -14,9 +16,6 @@ class RootFachinfo < Fachinfo; end
   end
 end
 
-
-require 'minitest/autorun'
-require 'flexmock/minitest'
 require 'state/drugs/fachinfo'
 
 module ODDB

diff --git a/test/test_state/feedbacks.rb b/test/test_state/feedbacks.rb
@@ -4,7 +4,6 @@
 
 $: << File.expand_path("../../src", File.dirname(__FILE__))
 
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
 require 'htmlgrid/labeltext'

diff --git a/test/test_state/hospitals/global.rb b/test/test_state/hospitals/global.rb
@@ -4,9 +4,6 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-#require 'state/global'
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
 require 'view/welcomehead'

diff --git a/test/test_state/hospitals/hospital.rb b/test/test_state/hospitals/hospital.rb
@@ -4,11 +4,9 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'view/welcomehead'
 require 'state/hospitals/hospital'
 require 'state/hospitals/setpass'

diff --git a/test/test_state/pharmacies/pharmacy.rb b/test/test_state/pharmacies/pharmacy.rb
@@ -3,11 +3,9 @@
 
 $: << File.expand_path("../../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'view/welcomehead'
 require 'state/pharmacies/setpass'
 require 'state/pharmacies/pharmacy'

diff --git a/test/test_state/setpass.rb b/test/test_state/setpass.rb
@@ -4,11 +4,9 @@
 
 $: << File.expand_path("../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'state/setpass'
 
 module ODDB 

diff --git a/test/test_state/suggest_address.rb b/test/test_state/suggest_address.rb
@@ -4,11 +4,9 @@
 
 $: << File.expand_path("../../src", File.dirname(__FILE__))
 
-require 'state/global'
-
-
 require 'minitest/autorun'
 require 'flexmock/minitest'
+require 'state/global'
 require 'state/suggest_address'
 require 'util/mail'