HLD: Accessible labels and localization in Nimble #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmithNI
requested review from
rajsite,
jattasNI,
atmgrifter00 and
mollykreis
as code owners
mollykreis
reviewed
May 26, 2023
jattasNI
reviewed
May 26, 2023
rajsite
reviewed
Jun 3, 2023
rajsite
reviewed
Jun 4, 2023
jattasNI
approved these changes
Jun 9, 2023
5 tasks
|
@atmgrifter00 @mollykreis I've updated this HLD and the prototype based on some discussions Jesse Milan and I had last week. I reset you since it should be in a good state for additional feedback if you have any, otherwise it's mostly waiting for Milan's signoff. |
rajsite
approved these changes
Jun 13, 2023
mollykreis
reviewed
Jun 13, 2023
atmgrifter00
approved these changes
Jun 13, 2023
… providers, update some prototype links
mollykreis
approved these changes
Jun 14, 2023
1 task
1 task
msmithNI
added a commit
that referenced
this pull request
Jul 27, 2023
# Pull Request ## 🤨 Rationale Resolves #1090 In [PR discussion on #1272](#1272 (comment)), we decided that the per-component accessibility notes would be better documented in Storybook (by the other component docs), instead of in accessibility.md. Resolves #1393 ## 👩💻 Implementation For components with accessibility notes not already documented in Storybook: - Create an mdx docs page for them, if it wasn't already present. Based on PR comments on the recent PR by Jesse, I think this is the general direction we're going for component docs. - Add a Usage Docs / Accessibility section at the bottom, and add the notes from accessibility.md. The button/spinner mdx have these sections, so again following the existing patterns. ## 🧪 Testing Manual verification in Storybook. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
#1090
👩💻 Implementation
N/A (HLD and doc updates)
🧪 Testing
N/A
✅ Checklist