Skip to content

Commit

Permalink
Restore AppCompat themes for some material components (LawnchairLaunc…
Browse files Browse the repository at this point in the history
…her#4811)

We still rely on them for using material views.

```
java.lang.IllegalArgumentException: The style on this component requires your app theme to be Theme.AppCompat (or a descendant).
	at com.google.android.material.internal.ThemeEnforcement.checkTheme(ThemeEnforcement.java:247)
	at com.google.android.material.internal.ThemeEnforcement.checkAppCompatTheme(ThemeEnforcement.java:212)
	at com.google.android.material.internal.ThemeEnforcement.checkCompatibleTheme(ThemeEnforcement.java:147)
	at com.google.android.material.internal.ThemeEnforcement.obtainStyledAttributes(ThemeEnforcement.java:76)
	at com.google.android.material.progressindicator.BaseProgressIndicatorSpec.<init>(BaseProgressIndicatorSpec.java:92)
	at com.google.android.material.progressindicator.CircularProgressIndicatorSpec.<init>(CircularProgressIndicatorSpec.java:76)
	at com.google.android.material.progressindicator.CircularProgressIndicatorSpec.<init>(CircularProgressIndicatorSpec.java:68)
	at com.google.android.material.progressindicator.CircularProgressIndicatorSpec.<init>(CircularProgressIndicatorSpec.java:63)
	at com.google.android.material.progressindicator.CircularProgressIndicator.createSpec(CircularProgressIndicator.java:87)
	at com.google.android.material.progressindicator.CircularProgressIndicator.createSpec(CircularProgressIndicator.java:58)
	at com.google.android.material.progressindicator.BaseProgressIndicator.<init>(BaseProgressIndicator.java:144)
	at com.google.android.material.progressindicator.CircularProgressIndicator.<init>(CircularProgressIndicator.java:78)
	at com.google.android.material.progressindicator.CircularProgressIndicator.<init>(CircularProgressIndicator.java:73)
	at com.google.android.material.progressindicator.CircularProgressIndicator.<init>(CircularProgressIndicator.java:69)
	at app.lawnchair.views.LauncherPreviewView.<init>(LauncherPreviewView.kt:46)
	at app.lawnchair.backup.ui.CreateBackupViewModel.captureScreenshot(CreateBackupViewModel.kt:58)
	at app.lawnchair.backup.ui.CreateBackupViewModel.access$captureScreenshot(CreateBackupViewModel.kt:24)
	at app.lawnchair.backup.ui.CreateBackupViewModel$1.invokeSuspend(CreateBackupViewModel.kt:38)
```
  • Loading branch information
Goooler authored and nulldrf committed Sep 19, 2024
1 parent a193435 commit e31cce4
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
9 changes: 9 additions & 0 deletions lawnchair/res/values-night/themes.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>

<resources xmlns:tools="http://schemas.android.com/tools">
<style name="Theme.Lawnchair" parent="Base.Theme.Lawnchair">
<item name="android:colorBackground">#ff121212</item>
<item name="android:windowLightStatusBar" >false</item>
<item name="android:windowLightNavigationBar" tools:ignore="NewApi">false</item>
</style>
</resources>
4 changes: 2 additions & 2 deletions lawnchair/res/values/themes.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
<item name="android:colorBackground">@color/white_50</item>
</style>

<style name="Base.Theme.MaterialThemeBuilder" parent="android:Theme.Material.Light.NoActionBar">
<style name="Base.Theme.MaterialThemeBuilder" parent="Theme.AppCompat.DayNight.NoActionBar">
<item name="android:statusBarColor" tools:ignore="NewApi">?android:attr/colorBackground</item>
<item name="android:windowLightStatusBar" tools:ignore="NewApi">true</item>
<item name="android:navigationBarColor" tools:ignore="NewApi">?android:attr/colorBackground</item>
<item name="android:windowLightNavigationBar" tools:ignore="NewApi">true</item>
</style>

<style name="Theme.Transparent" parent="android:Theme.Material.Light">
<style name="Theme.Transparent" parent="Theme.AppCompat.Light">
<item name="android:windowIsTranslucent">true</item>
<item name="android:windowAnimationStyle">@null</item>
<item name="android:windowBackground">@android:color/transparent</item>
Expand Down

0 comments on commit e31cce4

Please sign in to comment.