[Shawn Tan Jing Kai] iP #486

shawnkai · 2022-08-27T09:18:06Z

Duke

“Your mind is for having ideas, not holding them.” – David Allen

Duke frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 👍
And it is FREE!

Features:

Managing tasks
Managing deadlines
Reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

    public static void main(String[] args) throws IOException {
        Storage storage = new Storage();
        TaskList tasks = storage.loadFile();
        Parser parser = new Parser(tasks, storage);
        UI ui = new UI();
        ui.welcomeUser();
        String input = ui.readInput();  // Read user input
        while (!input.equals("bye")) {
            parser.parse(input);
            input = ui.readInput(); // Read next user input
        }
        ui.sayBye();
    }

…ist, UI

desmondyst

LGTM, just some small nits I pointed out in the comments. Perhaps u can consider having a task package and putting all the files that extends Task inside. Keep up the good work!

desmondyst · 2022-08-31T15:34:09Z

src/main/java/duke/Deadline.java

+        this.by = LocalDate.parse(by);
+    }
+
+    @Override


Good that you remember to add Override annotations!

desmondyst · 2022-08-31T15:38:42Z

src/main/java/duke/Parser.java

+    String dummyString;
+    Task dummyTask;
+    int counter;
+    int start;
+    int end;


Should there be access modifiers for these fields? 🤔 Same with codes in other files.

desmondyst · 2022-08-31T15:41:52Z

src/main/java/duke/Parser.java

+                System.out.println("Nice! I've marked this task as done:\n" +
+                        "[" + tasks.get(counter).getStatusIcon() + "] " + tasks.get(counter).getDescription());
+                storage.saveFile(tasks);
+


Perhaps u can remove the newline between if and else if statements etc? Same go with other lines of code.

Suggested change

desmondyst · 2022-08-31T15:47:10Z

src/main/java/duke/Storage.java

+            Files.createDirectories(Paths.get("data"));
+            this.file = new File("data/tasks.txt");
+            file.createNewFile();
+        } catch (IOException e) {


Should this catchblock be empty? 💭

desmondyst · 2022-08-31T15:49:06Z

src/main/java/duke/Task.java

+        return "[" + this.getStatusIcon() + "] " + this.getDescription();
+    }
+
+    String saveStringToFile() {


Missing access modifier!

desmondyst · 2022-08-31T15:49:47Z

src/test/java/duke/EventTest.java

+
+public class EventTest {
+    @Test
+    public void getTaskTypeTest(){


Suggested change

public void getTaskTypeTest(){

public void getTaskTypeTest() {

desmondyst · 2022-08-31T15:49:55Z

src/test/java/duke/EventTest.java

+    }
+
+    @Test
+    public void toStringTest(){


Suggested change

public void toStringTest(){

public void toStringTest() {

cxyterence

Your code generally looks good :D
There are some minute minor details that you might want to take note of

cxyterence · 2022-09-01T02:26:31Z

src/main/java/duke/Deadline.java

+
+public class Deadline extends Task {
+
+    protected LocalDate by;


Perhaps you might want to consider a more descriptive variable name like byDate, so that readers can easily differentiate between this variable and the other by parameter in your constructor

cxyterence · 2022-09-01T02:29:54Z

src/main/java/duke/Event.java

+
+public class Event extends Task {
+
+    protected LocalDate at;


Similar to Deadline.java, you could consider a more descriptive variable name like atDate

cxyterence · 2022-09-01T02:35:44Z

src/main/java/duke/Todo.java

+package duke;
+public class Todo extends Task {
+
+    protected String by;


You can consider removing this variable declaration since it's not being used

…java and parser.java

Assertions are not existent in the code to verify bugs. As such, certain bugs might not be detected in code. Use assert feature to document important assumptions that should hold at various points in the code. This is to prevent major bugs in the code such as description of Tasks being null.

Add assertions to code

# Conflicts: # src/main/java/duke/Parser.java

Duke is unable to provide a reminder function that can remind the user of upcoming events or deadlines in the coming week. Reminder function should be added so that user can easily know what are the upcoming events and deadlines. Let's have a reminder function that can allow the user to know about the upcoming deadlines and events within the next week. Typing in "Reminder" returns the deadlines and events for the next 7 days. E.g. Typing "Reminder" on 12 September 2022 will return the deadlines and events from 12 September 2022 (Exclusive) to 19 September 2022 (Exclusive).

damithc and others added 21 commits July 31, 2022 17:20

Add Gradle support

556af3f

edited Duke.java. completed Level-1

667d38b

edited duke.java and completed level 2

d1f1407

added task.java

4e2d26f

edited duke.java

5efa3fb

edited task.java and added 3 subclasses

534362c

edited duke.java

0d84d4e

added DukeException.java and edited Duke.java

f95c304

edited Duke.java

8fe5496

removed emoji from duke.java

3792d6f

resolved A-TextUiTesting issue

86a4055

edits made to several files for level 7

223aeab

edited deadline.txt and event.txt so they can recognise dates

407f442

Merge branch 'branch-Level-7'

0bcc053

Merge branch 'branch-Level-8'

bbbbfdf

Extracted code from Duke.java to form classes: Parser, Storage, TaskL…

3f20ab1

…ist, UI

put all classes in one package duke

68232ef

Merge remote-tracking branch 'add-gradle-support/add-gradle-support'

0f48dff

created test class for event and todo classes

d628eb8

changes made to input.txt

bfcd7cf

added data.txt file to gitignore

4b5dffc

desmondyst reviewed Aug 31, 2022

View reviewed changes

cxyterence reviewed Sep 1, 2022

View reviewed changes

shawnkai added 7 commits September 1, 2022 16:04

added javadocs

869c1fc

Tweak code to comply with coding standards

1fd5ddd

edited parser.java and tasklist.java to include the "find" command

5051a59

Merge branch 'A-JavaDoc'

c45b8a6

Merge branch 'branch-A-CodingStandard'

65589f2

Merge branch 'branch-Level-9'

6174930

add dialogbox.java and launcher.java and 2 images for gui, edit duke.…

240430a

…java and parser.java

shawnkai and others added 11 commits September 11, 2022 12:27

refactor code and improve code quality

49ec229

Merge pull request #3 from shawnkai/branch-A-Assertions

6d2b975

Add assertions to code

Merge branch 'master' of https://github.com/shawnkai/ip

9e6b2c5

Merge branch 'branch-A-CodeQuality'

bcbc1b5

# Conflicts: # src/main/java/duke/Parser.java

Merge branch 'branch-AddAnExtension'

96d8c8f

Update Readme and add screenshot of GUI

b9cd54c

edit user guide

4e9d991

create new jar file and edit file name from Launcher.java to Main.java

15d7db1

edit ui.png

ab144a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Shawn Tan Jing Kai] iP #486

[Shawn Tan Jing Kai] iP #486

shawnkai commented Aug 27, 2022 •

edited

Loading

desmondyst left a comment

desmondyst Aug 31, 2022

desmondyst Aug 31, 2022

desmondyst Aug 31, 2022

desmondyst Aug 31, 2022

desmondyst Aug 31, 2022

desmondyst Aug 31, 2022

desmondyst Aug 31, 2022

cxyterence left a comment

cxyterence Sep 1, 2022

cxyterence Sep 1, 2022

cxyterence Sep 1, 2022

	public void getTaskTypeTest(){
	public void getTaskTypeTest() {

[Shawn Tan Jing Kai] iP #486

Are you sure you want to change the base?

[Shawn Tan Jing Kai] iP #486

Conversation

shawnkai commented Aug 27, 2022 • edited Loading

Duke

desmondyst left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cxyterence left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shawnkai commented Aug 27, 2022 •

edited

Loading