Core: make the default IPC mode for docker to host (#1616)

oap-project · Jul 3, 2023 · 1eebf17 · 1eebf17
1 parent fdf3c61
commit 1eebf17
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/python/cloudtik/core/_private/command_executor/docker_command_executor.py b/python/cloudtik/core/_private/command_executor/docker_command_executor.py
@@ -346,6 +346,7 @@ def run_init(self, *, as_head: bool, file_mounts: Dict[str, str],
                 labels=self.docker_config.get("labels"),
                 port_mappings=self.docker_config.get("port_mappings"),
                 mounts_mapping=self.docker_config.get("mounts_mapping", True),
+                ipc_mode=self.docker_config.get("ipc_mode"),
             )
             self.run_with_retry(
                 start_command, run_env="host")

diff --git a/python/cloudtik/core/_private/docker.py b/python/cloudtik/core/_private/docker.py
@@ -175,9 +175,9 @@ def _docker_start_cmds(user, image, mounts, data_disks, container_name,
         numactl_flag, network_flag
     ]
 
-    if ipc_mode:
-        ipc_flag = "--ipc={}".format(ipc_mode)
-        docker_run += [ipc_flag]
+    # default IPC mode to host
+    ipc_flag = "--ipc={}".format(ipc_mode if ipc_mode else "host")
+    docker_run += [ipc_flag]
 
     if cpus:
         cpus_flag = "--cpus={}".format(cpus)

diff --git a/python/cloudtik/providers/_private/virtual/virtual_container_scheduler.py b/python/cloudtik/providers/_private/virtual/virtual_container_scheduler.py
@@ -434,6 +434,7 @@ def _start_container(self, node_config, tags):
         # make a copy before change it
         docker_config = copy.deepcopy(docker_config)
         docker_config["mounts_mapping"] = False
+        docker_config["ipc_mode"] = "private"
 
         port_mappings = node_config.get("port_mappings")
         if port_mappings: