Skip to content

Commit

Permalink
Switch to Binaryen 118
Browse files Browse the repository at this point in the history
  • Loading branch information
vouillon committed Jul 16, 2024
1 parent 3062c38 commit 9648cfb
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build-wasm_of_ocaml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ jobs:
- name: Install node
uses: actions/setup-node@v4
with:
node-version: v22.0.0-v8-canary2024030314ed92e804
node-version: 22

- name: Restore cached binaryen
id: cache-binaryen
uses: actions/cache/restore@v4
with:
path: binaryen
key: ${{ runner.os }}-binaryen-version_117
key: ${{ runner.os }}-binaryen-version_118

- name: Checkout binaryen
if: steps.cache-binaryen.outputs.cache-hit != 'true'
Expand All @@ -47,7 +47,7 @@ jobs:
repository: WebAssembly/binaryen
path: binaryen
submodules: true
ref: version_117
ref: version_118

- name: Install ninja
if: steps.cache-binaryen.outputs.cache-hit != 'true'
Expand All @@ -65,7 +65,7 @@ jobs:
uses: actions/cache/save@v4
with:
path: binaryen
key: ${{ runner.os }}-binaryen-version_117
key: ${{ runner.os }}-binaryen-version_118

- name: Set binaryen's path
run: |
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ Wasm_of_ocaml is a fork of Js_of_ocaml which compiles OCaml bytecode to WebAssem

## Requirements

Wasm_of_ocaml relies on the Binaryen toolchain; currently, only [version 117](https://github.com/WebAssembly/binaryen/releases/tag/version_117) is supported. Binaryen commands must be in the PATH for wasm_of_ocaml to function.
Wasm_of_ocaml relies on the Binaryen toolchain; currently, only [version 118](https://github.com/WebAssembly/binaryen/releases/tag/version_118) or greater are supported. Binaryen commands must be in the PATH for wasm_of_ocaml to function.

## Supported engines

The generated code works with Chrome 11.9, [node V8 canary](https://nodejs.org/download/v8-canary/v21.0.0-v8-canary20230927fa59f85d60/) and [Firefox 122](https://www.mozilla.org/en-US/firefox/new/).
The generated code works with Chrome 11.9, Node.js 22 and Firefox 122 (or more recent versions of these applications).

In particular, the output code requires the following [Wasm extensions](https://webassembly.org/roadmap/) to run:
- [the GC extension](https://github.com/WebAssembly/gc), including functional references and 31-bit integers
Expand Down
2 changes: 1 addition & 1 deletion runtime/wasm/dune
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
(system
"which wasm-merge > /dev/null || (echo 'Error: Binaryen tools not found in the PATH'; false)")
(system
"wasm-merge --version | grep -q 'version 117' || (echo 'Error: Binaryen version 117 is currently required'; false)")
"wasm-merge --version | grep -q 'version \\(11[789]\\|1[2-9][0-9]\\)' || (echo 'Error: Binaryen version 118 or greater is currently required'; false)")
(pipe-stdout
(run
wasm-merge
Expand Down

0 comments on commit 9648cfb

Please sign in to comment.