Cookbook recipe for matrix addition and multiplication #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of the matrix addition and multiplication using the Array module of the standard library and integer arrays. Note that it relies on vector addition and dot product to define the matrix operations in a functional style. It can be useful for those cases where Owl library can't be used, otherwise these operations of the matrices are defined in a, probably, more performant way in Owl. Easy changes to implement it for floats.
|
Hello. I realised that some recipes have a kind of discussion at the beginning. I don't know exactly the syntax for that but the initial comments in the recipe are aimed to be a kind of discussion. I can work on it. |
Matrix addition and multiplication: A discussion block replace long comment at the beginning of code. The comments of several functions has been clarified, and the final tests has been extended to cover more cases. An explation of how to extend functions to floats has been added in discussion.
christinerose
approved these changes
Aug 29, 2024
|
This seems to be finished and ready, but their integration seems frozen since 29-Aug. Do I need to do something more? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have prepared a recipe for the matrix addition and multiplication. In this case using the Array module of the standard library and implemented using integer elements for the arrays.
Note that it relies on vector addition and dot product of vectors to define the matrix operations in a kind of functional style (rather than using loops). Also in the process the recipe defines additional useful functions:
It can be useful for those cases where Owl library can't be used, otherwise these operations of the matrices are defined in (a more performant way) in Owl.
This example use integer vector and matrix, but I am happy to implement for floats if preferred.
Thanks and kind regards,
Ramiro.