Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opam switch activation instruction on Windows #2709

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Fix opam switch activation instruction on Windows #2709

merged 5 commits into from
Sep 24, 2024

Conversation

cuihtlauac
Copy link
Collaborator

@cuihtlauac cuihtlauac commented Sep 19, 2024 •
edited
Loading

Fix #2707

  • Missing space (typo)
  • Endline code (escape sequence)
  • Antivirus (add "takes minutes" text)

@cuihtlauac cuihtlauac mentioned this pull request Sep 19, 2024
Closed
@cuihtlauac
Copy link
Collaborator Author

cuihtlauac commented Sep 20, 2024 •
edited
Loading

I've updated the eml code. I see \r?\n on both pages in

  • Linux/Chrome
  • Linux/Firefox
  • Android/Chrome
  • iOS/Safari
  • Windows 11/Edge

On ChromeOS, I can't display /install#windows. That's an unrelated issue.

dra27
dra27 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@cuihtlauac cuihtlauac merged commit e8432c6 into main Sep 24, 2024
3 checks passed
@cuihtlauac cuihtlauac deleted the fix-install-win branch September 24, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 approved these changes

@christinerose christinerose christinerose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The commands to activate the opam switch on windows are wrong
3 participants
@cuihtlauac @dra27 @christinerose