address review comment

ocaml · Nov 30, 2023 · 6d728a9 · 6d728a9
1 parent f7fa297
commit 6d728a9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/parser/parse_error.ml b/src/parser/parse_error.ml
@@ -82,6 +82,6 @@ let truncated_code_block_meta : Loc.span -> Warning.t =
 let truncated_code_block : Loc.span -> Warning.t =
   Warning.make ~suggestion:"add ']}'." "Missing end of code block."
 
-let unclosed_table : Loc.span -> Warning.t =
-  Warning.make ~suggestion:"try to add '}' at the end of table content."
-    "Unclosed table '{t ...' or '{table ...'"
+let invalid_table_syntax : ?suggestion:string -> Loc.span -> Warning.t =
+ fun ?suggestion ->
+  Warning.make ?suggestion "Unclosed table '{t ...' or '{table ...'"
diff --git a/src/parser/syntax.ml b/src/parser/syntax.ml
@@ -126,7 +126,9 @@ module Reader = struct
           junk input;
           `End (acc, next_token.location)
       | `End ->
-          Parse_error.unclosed_table next_token.location |> add_warning input;
+          Parse_error.invalid_table_syntax next_token.location
+            ~suggestion:"try to add '}' at the end of table content."
+          |> add_warning input;
           junk input;
           `End (acc, next_token.location)
       | `Space _ | `Single_newline _ | `Blank_line _ ->
@@ -1345,7 +1347,8 @@ and light_table_row ~parent_markup ~last_loc input =
     let next_token = peek input in
     match next_token.value with
     | `End ->
-        Parse_error.unclosed_table next_token.location |> add_warning input;
+        Parse_error.invalid_table_syntax next_token.location
+        |> add_warning input;
         junk input;
         (`Stop, return acc_row acc_cell, next_token.location)
     | `Right_brace ->