Set Component.Delayed.eager to true #1014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The benchmarks first reported +3.3% compile time and +8.9% link time. I then replaced the implementation of Delayed with the identity function, the numbers are +2.5% for compile and +8.1% for link, confirming it's not noise. I explain such a low number with that |
On my machine, this doesn't have an impact on the benchmarks.
|
Since #1012 we can see that the slowest compile invocation takes 36% more time. |
|
This was just a test and isn't meant to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine, this doesn't have an impact on the benchmarks.
I open this PR so it can run on the benchmarks infrastructure and be compared to previous runs.