Remove margin of first child of odoc-content #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is still a gap between preamble and content:
This is due to that. Even if smaller than before, this gap will be unexpected to most people who do not know there is a notion of preamble in odoc. Now that I understood that, I think it would be better not to remove the gap, but to make it understandable:
That being said, go with what you prefer. |
|
As far as I understand, the gap was there before we switched to grid, and its quite reasonable to have a gap here. |
|
Indeed, this PR reverts the introduction of a larger gap from #999. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the gap in between the preamble and the content without changing other margins, or changing the structure of the HTML.