Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify children order in frontmatter #1193

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Commits on Aug 28, 2024

  1. Remove impossible page reference from the possible values

    Page don't and won't use dot references as in `page1.page2`.
    panglesd committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7a1089d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f58b305 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    62e1457 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    a3c3ec7 View commit details
    Browse the repository at this point in the history
  2. Allow specification of children order in index page

    Use
    
    ```
    children: page1 page2 page3
    ```
    
    in the frontmatter
    panglesd committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    cb8b95d View commit details
    Browse the repository at this point in the history
  3. Children order: do not model that with references

    Children order specifies order in an index page for the current directory. It
    has to specify what is a page and what is a directory, as we can have:
    
    ```
    doc/
      index
      foo
      foo/
        index
        bar
    ```
    
    In the specification of the order in `doc/index`, we must make the difference
    between the foo page and the foo directory. This was not practical with
    references. So instead, the order specification has its own type.
    panglesd committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ed56325 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    436381a View commit details
    Browse the repository at this point in the history
  5. Children order: more lax syntax

    Allow sequences of spaces in a row: `children:      page1           page2`.
    panglesd committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    272bf96 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    391e4b1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fe8edb9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    531e8d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Children order review: reduce diff with style improvements

    Unexpose unnecessary functions
    open modules
    use mli for model/frontmatter
    panglesd committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5cc3d5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d90d0f View commit details
    Browse the repository at this point in the history
  3. Add a warning when specifying children order in non-index pages

    Co-authored-by: Jules Aguillon <[email protected]>
    panglesd and Julow committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ce8314d View commit details
    Browse the repository at this point in the history
  4. Children order: Refactor sidebar types

    Directly take children order into account.
    
    Co-authored-by: Jules Aguillon <[email protected]>
    panglesd and Julow committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    de0d278 View commit details
    Browse the repository at this point in the history
  5. Children order: Add omitted children at the end of the ordering

    Co-authored-by: Jules Aguillon <[email protected]>
    panglesd and Julow committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    67c233f View commit details
    Browse the repository at this point in the history
  6. Children order: Add a warning when a children is omitted

    Co-authored-by: Jules Aguillon <[email protected]>
    panglesd and Julow committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    93aa604 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    979868d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dfdf6db View commit details
    Browse the repository at this point in the history
  3. Do not open Path.Identifier

    But alias it to Id. It was bringing too many values in scope (eg shadowing
    compare).
    panglesd committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e7e2626 View commit details
    Browse the repository at this point in the history