-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 packages from ocaml-sf/learn-ocaml at 1.0.0 #25251
Conversation
Cc @AltGr, ideas why we get |
Co-authored-by: Weng Shiwei 翁士伟 <[email protected]>
OK, thanks @mseri ! (and of course, we'll report back these patches in learn-ocaml master as soon as the PR is merged) |
FWIW, adding a dependency to |
@AltGr OK thanks for your precision!! Do you want that I open a follow-up PR in this repo to replace the |
The conflict is pervasive, appears in very many packages, we also tried to get rid of it a number of times but I did not know that it was problematic for the solver: #24263 |
Alright that was just my 2¢, if it's a known issue and the solution works I don't want to mingle :) |
I hope my comment did not sound dismissive, I had the opposite intention: I appreciated your comment a lot, I was not aware of the extra burden on the solver and I think it is very relevant in the discussion I linked above, even more so since it is pervasive. Now it is linked there so we can refer to this the next time is discussed! |
This pull-request concerns:
learn-ocaml.1.0.0
: The learn-ocaml online platform (engine)learn-ocaml-client.1.0.0
: The learn-ocaml clientCc @erikmd @yurug @AltGr FYI
1.0.0 (2024-02-12)
⚠ BREAKING CHANGES
Prefix pre-compilation indicates the related commits below (sorted in chronological order).
depend.txt
(it will need rewriting; relying on the new server engine).Features
register_sampler
calls (3cd75f5)test_libs.txt
file in exercises (d22a788)--replace
option (82d9bea)learn-ocaml build --build-dir=[./_learn-ocaml-build]
to increase compatibility with existing workflows (#585) (6535692)Bug Fixes
mutation_testing
test lib (c432909)mutation_test
(32ad13e)prepare.ml
file (365cbb7)lsof -Q
which is only available from lsof 4.95.0 (a242084), closes #580--replace
(#584) (fe2a806), closes #583Performance Improvements
learn-ocaml build
parallel by default (eaad14c)Code Refactoring
recorder
toppx_autoregister
(99e913d)Build System
make testrun
parallel (46631d8)CI/CD
hub
(not installed anymore) withgh
(cad060f)Documentation
depend.txt
(it will need rewriting) (9155145)test_libs.txt
(2c89d9e)🐫 Pull-request generated by opam-publish v2.3.0