Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package cvc5.1.1.3-unreleased #26037

Merged
merged 11 commits into from
Aug 2, 2024

Conversation

joaomhmpereira
Copy link
Contributor

cvc5.1.1.3-unreleased

OCaml bindings for the cvc5 SMT solver
OCaml bindings for the cvc5 SMT solver



🐫 Pull-request generated by opam-publish v2.3.0

@joaomhmpereira joaomhmpereira marked this pull request as draft June 7, 2024 16:10
@joaomhmpereira
Copy link
Contributor Author

joaomhmpereira commented Jun 13, 2024

I think this is finally ready for review. A note on the remaining errors:

@joaomhmpereira joaomhmpereira marked this pull request as ready for review June 13, 2024 22:04
@mseri
Copy link
Member

mseri commented Jul 9, 2024

Is the version correct? Right now it is going to be released as cvc5 with version 1.1.3-unreleased

Did I understand correctly that we need to add an upper bound to smtml to xcx5 < 1.1.3 ?

@mseri mseri added the question label Jul 9, 2024
@joaomhmpereira
Copy link
Contributor Author

Is the version correct? Right now it is going to be released as cvc5 with version 1.1.3-unreleased

The version 1.1.3-unreleased refers to the latest version of cvc5 that is available but has not yet been formally released. Maybe it's better to keep the versioning of cvc5 OCaml bindings independent to the version of the actual solver and start at 0.1.0?

Did I understand correctly that we need to add an upper bound to smtml to xcx5 < 1.1.3 ?

This is only the case for smtml.0.1.1 as the issue has been addressed in the following releases

@shonfeder
Copy link
Collaborator

The version 1.1.3-unreleased refers to the latest version of cvc5 that is available but has not yet been formally released. Maybe it's better to keep the versioning of cvc5 OCaml bindings independent to the version of the actual solver and start at 0.1.0?

If the intent and nature of these bindings is that are tied to that specific version of cvc5, and entail installation of it and only support compatibility with it, then I think it makes sense to have the version of this package track the version of cvc5 directly. WDYT, ts that the case?

@mseri
Copy link
Member

mseri commented Aug 1, 2024

I am not against this. In this case, I think you should release it as version 1.1.3~unreleased. In this way, once 1.1.3 is released, if there are changes, version 1.1.3 will appear as the latest version

@joaomhmpereira
Copy link
Contributor Author

I am not against this. In this case, I think you should release it as version 1.1.3~unreleased. In this way, once 1.1.3 is released, if there are changes, version 1.1.3 will appear as the latest version

I have corrected the version, I think now it's ready

@mseri
Copy link
Member

mseri commented Aug 2, 2024

I will send a pr with the upper bounds of smtml and then publish. Can you look at the failure on debian-unstable? Is that expected?

mseri added a commit to mseri/opam-repository that referenced this pull request Aug 2, 2024
@mseri
Copy link
Member

mseri commented Aug 2, 2024

Thanks

@mseri mseri merged commit fe8dffa into ocaml:master Aug 2, 2024
0 of 2 checks passed
@joaomhmpereira joaomhmpereira deleted the opam-publish-cvc5.1.1.3-unreleased branch August 2, 2024 16:34
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants