Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitstring sources #26074

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Update bitstring sources #26074

merged 2 commits into from
Aug 7, 2024

Conversation

CharlesAverill
Copy link
Contributor

Old versions of the bitstring package pointed their source to a now-defunct Bitbucket repository. This PR updates the sources to the currently-maintained Github repository https://github.com/xguerin/bitstring

@mseri
Copy link
Member

mseri commented Jun 13, 2024

Looks like some checksums are different. We should try to get the old packages from the caches: https://github.com/ocaml/opam-repository/wiki/FAQ#how-to-find-lost-archives-of-packages

@@ -31,7 +31,7 @@ You can use this module to both parse and generate binary formats, files and pro
Bitstring handling is added as primitives to the language, making it exceptionally simple to use and very powerful."""
flags: light-uninstall
url {
src: "https://bitbucket.org/thanatonauts/bitstring/get/v2.1.0.tar.gz"
src: "https://github.com/xguerin/bitstring/archive/v2.1.0.tar.gz"
Copy link
Collaborator

@shonfeder shonfeder Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/bitstring/bitstring.2.1.0/opam Outdated Show resolved Hide resolved
packages/bitstring/bitstring.2.1.1/opam Outdated Show resolved Hide resolved
packages/bitstring/bitstring.3.0.0/opam Outdated Show resolved Hide resolved
packages/bitstring/bitstring.3.1.0/opam Outdated Show resolved Hide resolved
packages/bitstring/bitstring.3.1.1/opam Outdated Show resolved Hide resolved
@kit-ty-kate
Copy link
Member

those archives should probably be uploaded to https://github.com/ocaml/opam-source-archives/ instead of relying on ocamlpro's repository

@shonfeder
Copy link
Collaborator

Ah ok, makes sense. I'll do that when I have a moment.

Could you (or someone with perms) update https://github.com/ocaml/opam-repository/wiki/FAQ#how-to-find-lost-archives-of-packages so that the need for adding the sources to the archive in such cases is recorded?

@mseri
Copy link
Member

mseri commented Aug 1, 2024

Done

@mseri mseri merged commit 5aeb876 into ocaml:master Aug 7, 2024
1 of 2 checks passed
@mseri
Copy link
Member

mseri commented Aug 7, 2024

Sources are now all accessible

@shonfeder
Copy link
Collaborator

Thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants