Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA windows: do not fail when none of the packages can be installed #26080

Merged
merged 1 commit into from
Jun 13, 2024
Merged

GHA windows: do not fail when none of the packages can be installed #26080

merged 1 commit into from
Jun 13, 2024

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Jun 13, 2024 •
edited
Loading

Somehow the last $LASTEXITCODE seems to be carried over to the whole process

Should fix the issue seen in #26079

dra27
dra27 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a PR I'm about to open which also hit this, but I haven't actually tested with a failing PR

@kit-ty-kate kit-ty-kate merged commit a99ae79 into ocaml:master Jun 13, 2024
3 checks passed
@kit-ty-kate kit-ty-kate deleted the windows-ci branch June 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kit-ty-kate @dra27