[ci] Add cygwin bin directories to PATH #26508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something else is going on here - it shouldn’t be necessary to do this in a package build - I’ll endeavour to have a look tomorrow/next week |
|
This seems somewhat related to ocaml/opam#6181. To me the ideal solution seems to be for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these PATH entries, cygwin's binaries never get used. This means that
makeandbashand other executables are not used from cygwin, but from other preinstalled packages in the github actions runner (e.g. git bash and the preinstalled mingw).This causes build issues with certain packages, see:
#26501
aantron/luv#162