Add ocaml dependency to rusage
#26615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling rusage requires an OCaml compiler, thus this PR adds that dependency.
|
Also includes a |
|
Thanks, looks like it compiles with all ocaml version in the CI |
|
Yes, I was positively surprised I didn't need any constraints at all. It doesn't seem to work on Windows which is probably unsurprising, given it's some POSIX call and there's only limited support on Windows. Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling rusage requires an OCaml compiler, thus this PR adds that dependency.
The reasoning is the same as for #26610.
Upstream PR here: craigfe/ocaml-rusage#3