Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin: fix first local vcs fetch rsyncing all source #6221

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Oct 1, 2024

Backported in 2.3 with #6222

The origin of the issue is from the magic to retrieve the opam file even if it is not committed added in #4300. To do that, the local vcs url was changed to local rsync, in order to get all source not only committed files. In the next synchronisation, as opam file contains the vcs url, the synchronisation fixed that anomaly.

Fix #5809
Queued on #6135

@rjbou rjbou added KIND: BUG PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Oct 1, 2024
@rjbou rjbou added this to the 2.4.0~alpha1 milestone Oct 1, 2024
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

tests/reftests/pin.test Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KIND: BUG PR: QUEUED Pending pull request, waiting for other work to be merged or closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial pin of VCS directory includes untracked and ignored files [2.1 regression]
2 participants