Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several linting issues related to the new linter #87

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

Maelan
Copy link
Contributor

@Maelan Maelan commented Aug 3, 2022

Each of the two commits fixes one the following issues (which were both noted as FIXMEs in the test file).

  1. exception E = F : the equal sign was wrongly shown as an error; the fix is easy. This addresses a portion of spurious error on module type #84.
  2. fun ... : t -> e : the type context was wrongly running over -> ; the fix introduces a little extra bit of complexity (fun is now the start of a region rather than just a keyword) but it is simpler than I anticipated (thanks to the containedin= feature of Vim). This closes coloring is wrong in some contexts #86.

Remaining issues:

  • the test file has one remaining FIXME (but of much lesser importance, it is more a feature wish than an actual issue): class ['a] myclass ... where we’d like the type variable to be highlighted as such;
  • spurious error on module type #84 has one more issue: (module M) used as a type expression.

@copy copy merged commit 755d96c into ocaml:master Aug 4, 2022
@copy
Copy link
Collaborator

copy commented Aug 4, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coloring is wrong in some contexts
2 participants