-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add 32bit 5.2.0 job #1700
base: master
Are you sure you want to change the base?
[ci] Add 32bit 5.2.0 job #1700
Conversation
7229f1b
to
72f959d
Compare
Indeed, even if I did check So we either:
Any other idea? |
No need to run the tests. Just build/install like we do for older ocaml version |
@hhugo should we still do As of now the |
Caveats: - The OCaml switch in this case byte-only, so things are slow, as jsoo itself won't have a native mode - JS ppx libs 0.17 don't really support 32bit builds, this will likely become a problem in the future (if not now actually, for example `ppx_inline_test.0.17.0` fails to build) - jsCoq/coq-lsp works in this setup, which is IMO a great "data point" as to whether this setup is OK
@@ -82,7 +88,7 @@ jobs: | |||
# getting much better, but no luck yet, c.f: | |||
# https://github.com/ocaml/opam-repository/pull/26626 | |||
- name: Install apt 32-bit dependencies | |||
if: matrix.ocaml-compiler == 'ocaml-variants.4.14.2+options,ocaml-option-32bit' | |||
if: matrix.ocaml-compiler == 'ocaml-variants.4.14.2+options,ocaml-option-32bit' || matrix.ocaml-compiler == 'ocaml-variants.5.2.0+options,ocaml-option-32bit' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should should be able to use contains( matrix.ocaml-compiler, "ocaml-option-32bit")
Yes, we could. You could change the ci to respect skip test when skip-effect is false |
Caveats:
The OCaml switch in this case byte-only, so things are slow, as jsoo itself won't have a native mode
JS ppx libs 0.17 don't really support 32bit builds, this will likely become a problem in the future (if not now actually, for example
ppx_inline_test.0.17.0
fails to build)jsCoq/coq-lsp works in this setup, which is IMO a great "data point" as to whether this setup is OK
p.s: Coq stops working in 5.2.0 if I pass
--enable=effects
tho, the error isReason: Uncaught RangeError: Maximum call stack size exceeded
, is that worth reporting?