Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create federal senate app #430

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

giovanisleite
Copy link
Contributor

What is the purpose of this Pull Request?
Start the Federal Senate app.
It's a simple PR so that other contributions can happen simultaneously and get close to what we have in the chamber_of_deputies app

What was done to achieve this purpose?
I created a new django app federal_senate, a Reimbursement model based on the csv from serenata-toolbox project with some fields based on Reimbursement from chamber_of_deputies.

How to test if it really works?
Run the migrations and the tests docker-compose run --rm django python manage.py test jarbas/federal_senate/

Who can help reviewing it?
Anyone =)

@willianpaixao
Copy link
Contributor

Fixes #431

@giovanisleite giovanisleite changed the title Create federal senate app [WIP] Create federal senate app Jan 24, 2019
@caiocarrara
Copy link
Contributor

Hello, @giovanisleite. We're in a Serenata Sprint and there are a bunch of people willing to help. What is missing to this PR so it can be merged? We can help move it forward 😸

@caiocarrara
Copy link
Contributor

Hey @cuducos and @sergiomario, I checked out @giovanisleite branch and run it locally. It seems it's missing only register the new app models to the Dashboard. What do you think merging it to allow others work on this? This way we do not lose the work/contribution made by Giovani and enable new contributions to have the Senate on Jarbas.

@giovanisleite
Copy link
Contributor Author

Hello, @giovanisleite. We're in a Serenata Sprint and there are a bunch of people willing to help. What is missing to this PR so it can be merged? We can help move it forward

Sorry, I didn't see this message earlier.
This PR is part of the solution for #431, the first part to be exactly (Create Federal Senate app & Reimbursement model based on serenata-toolbox csv)

@giovanisleite giovanisleite changed the title [WIP] Create federal senate app Create federal senate app Oct 7, 2019
@giovanisleite
Copy link
Contributor Author

Now the new app is registered on the dashboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants